Merge pull request #1563 from scyzoryck/fix-issue-1562

fix(unions): Filter out null type
schmittjoh · Oct 31, 2024 · 362503d · 362503d
2 parents 43404be + 1946af2
commit 362503d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/Metadata/Driver/TypedPropertiesDriver.php b/src/Metadata/Driver/TypedPropertiesDriver.php
@@ -113,7 +113,14 @@ public function loadMetadataForClass(ReflectionClass $class): ?ClassMetadata
                 } elseif ($this->shouldTypeHintUnion($reflectionType)) {
                     $propertyMetadata->setType([
                         'name' => 'union',
-                        'params' => [$this->reorderTypes(array_map(fn (string $type) => $this->typeParser->parse($type), $reflectionType->getTypes()))],
+                        'params' => [
+                            $this->reorderTypes(
+                                array_map(
+                                    fn (string $type) => $this->typeParser->parse($type),
+                                    array_filter($reflectionType->getTypes(), [$this, 'shouldTypeHint']),
+                                ),
+                            ),
+                        ],
                     ]);
                 }
             } catch (ReflectionException $e) {

diff --git a/tests/Fixtures/TypedProperties/UnionTypedProperties.php b/tests/Fixtures/TypedProperties/UnionTypedProperties.php
@@ -8,6 +8,8 @@ class UnionTypedProperties
 {
     private int|bool|float|string $data;
 
+    private int|bool|float|string|null $nullableData;
+
     public function __construct($data)
     {
         $this->data = $data;