Skip to content
This repository has been archived by the owner on Oct 6, 2022. It is now read-only.

agreements and requiredField ClientErrors are only there because of tracking pod #202

Open
aliak00 opened this issue Sep 11, 2018 · 0 comments
Labels
maintenance question Further information is requested

Comments

@aliak00
Copy link
Contributor

aliak00 commented Sep 11, 2018

The two client errors:

  1. ClientErrors.agreements
    self.configuration.tracker?.error(.validation(.agreements), in: self.trackerScreenID)
  2. ClientError.requiredField
    self.configuration.tracker?.error(.validation(.requiredField(errorMessages)), in: self.trackerScreenID)

Are only there for tracking purposes and should not be exposed to the client as a "handleable" error.

Possible solution:

  • The tracker .validation error currently takes a ClientError so one possible fix would be to have a .validation(clientError: ClientError) and .validation(string: String) and just use a hardcoded tracker specific string with agreements missing.

On required field:

@aliak00 aliak00 added question Further information is requested maintenance labels Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant