Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS11 beta not showing more button. #37

Open
monish152 opened this issue Jun 13, 2017 · 5 comments
Open

iOS11 beta not showing more button. #37

monish152 opened this issue Jun 13, 2017 · 5 comments

Comments

@monish152
Copy link

No description provided.

@futuretap
Copy link
Contributor

futuretap commented Jun 21, 2017

Looks like it's not an easy task to fix that. The delete confirmation view that is used to add the custom buttons doesn't exist anymore in iOS 11. Instead, a UISwipeActionPullView is added directly to the UITableViewWrapperView, not the MSCMoreOptionTableViewCell. So we would have to hook into the table view, not the cell.

OTOH, iOS 11 adds its own mechanism for swipable cells (-tableView:trailingSwipeActionsConfigurationForRowAtIndexPath:).

@petarov
Copy link

petarov commented Oct 13, 2017

I stumbled upon the same issue today. Found a possible solution in Apple's forums, but yeah, it seems like a real challenge to bring that to iOS11 and lesser versions at the same time.

@scheinem
Copy link
Owner

Thanks for the link!

I think the best solution would be to improve the documentation and the demo project to show how to use this code for iOS 10 and below and the original Apple solution for iOS 11 at the same time?

What are your thoughts about that?

@petarov
Copy link

petarov commented Oct 13, 2017

Thanks for the feedback @scheinem. I'm perfectly fine with that.

I haven't tested the linked solution yet. I'm not a iOS developer, but I do need to make a couple of fixes in an app that uses MSCMoreOptionTableViewCell, so anything works for me at this point. 😉

@petarov
Copy link

petarov commented Oct 17, 2017

Solved it by using the gist by @scheinem. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants