Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New inspection level - SKIP #646

Open
mccartney opened this issue May 2, 2022 · 3 comments
Open

New inspection level - SKIP #646

mccartney opened this issue May 2, 2022 · 3 comments
Assignees
Labels

Comments

@mccartney
Copy link
Collaborator

Current inspection levels are: ERROR, WARNING, INFO.

I suggest to add a new one: (working name) SKIP. So that for instance one can set it as a default level for some inspections. I think that has the potential of simplifying the configuration - i.e. instead of disabling inspections, one would set their level to SKIP.

@eugene-sy
Copy link
Contributor

It feels like duplication to me.
The use case when one wants to see the issue in the output but not break the build is covered by INFO.
If one would not like to see the issue in the report can be achieved by disabling the inspection.
Do I miss a scenario?

@mccartney
Copy link
Collaborator Author

You are right. My point is that the notion of disabling the inspection could be replaced with a new level.

This way we wouldn't need to develop and maintain two separate sets of configuration properties which overlap. E.g. we currently have default values for levels, but no support for a inspection to be disabled by default, etc.

@eugene-sy
Copy link
Contributor

Oh, yes, I see your point.
My thinking led me to the idea of having both, the list of disabled inspections and the new inspection level. What you say is about replacing the disabled list with the inspection level.
It might also play well with the configuration file approach form #439

@eugene-sy eugene-sy mentioned this issue Sep 9, 2023
@eugene-sy eugene-sy self-assigned this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants