Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show duplicated IP in CP ingress external IPs list #4411

Merged

Conversation

eg-ayoub
Copy link
Contributor

@eg-ayoub eg-ayoub commented Sep 2, 2024

No description provided.

@eg-ayoub eg-ayoub requested a review from a team as a code owner September 2, 2024 14:17
@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Hello eg-ayoub,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@eg-ayoub eg-ayoub force-pushed the improvement/fix_kube_state_metrics_dupe_metrics branch 2 times, most recently from d8cbd0b to 8560c2b Compare September 2, 2024 14:28
@eg-ayoub eg-ayoub force-pushed the improvement/fix_kube_state_metrics_dupe_metrics branch 2 times, most recently from 56e7062 to 3147e2c Compare September 2, 2024 14:41
@eg-ayoub eg-ayoub force-pushed the improvement/fix_kube_state_metrics_dupe_metrics branch from 3147e2c to b713dcc Compare September 2, 2024 15:10
@eg-ayoub eg-ayoub force-pushed the improvement/fix_kube_state_metrics_dupe_metrics branch from b713dcc to 6b11312 Compare September 2, 2024 15:22
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing a changelog and it's good to me :)

@eg-ayoub
Copy link
Contributor Author

eg-ayoub commented Sep 2, 2024

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@eg-ayoub eg-ayoub force-pushed the improvement/fix_kube_state_metrics_dupe_metrics branch from ac51fae to e3121ad Compare September 2, 2024 20:42
@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

History mismatch

Merge commit #ac51faebbafaabf01eecd4f7bbd282198c0bf192 on the integration branch
w/128.0/improvement/fix_kube_state_metrics_dupe_metrics is merging a branch which is neither the current
branch improvement/fix_kube_state_metrics_dupe_metrics nor the development branch
development/128.0.

It is likely due to a rebase of the branch improvement/fix_kube_state_metrics_dupe_metrics and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@eg-ayoub
Copy link
Contributor Author

eg-ayoub commented Sep 2, 2024

/reset

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 2, 2024

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 3, 2024

Build failed

The build for commit did not succeed in branch w/128.0/improvement/fix_kube_state_metrics_dupe_metrics.

The following options are set: approve

@eg-ayoub
Copy link
Contributor Author

eg-ayoub commented Sep 3, 2024

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 3, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/127.0

  • ✔️ development/128.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/125.0
  • development/126.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye eg-ayoub.

The following options are set: approve

@bert-e bert-e merged commit e3121ad into development/127.0 Sep 3, 2024
26 checks passed
@bert-e bert-e deleted the improvement/fix_kube_state_metrics_dupe_metrics branch September 3, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants