Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make KubeJobNotCompleted configurable in prometheus operator config #4128

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Make KubeJobNotCompleted configurable in prometheus operator config #4128

merged 3 commits into from
Sep 5, 2023

Conversation

eg-ayoub
Copy link
Contributor

No description provided.

@eg-ayoub eg-ayoub requested a review from a team as a code owner August 22, 2023 09:15
@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Hello eg-ayoub,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@eg-ayoub eg-ayoub force-pushed the improvement/configure-KubeJobNotCompleted-alert branch from 18a7721 to 934d49b Compare August 22, 2023 09:28
@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

History mismatch

Merge commit #14db4d57e694c7635bdfb1554f2ab3a2e4150eee on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@eg-ayoub
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

TeddyAndrieux
TeddyAndrieux requested changes Aug 22, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls Show resolved Hide resolved
salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls Outdated Show resolved Hide resolved
salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Aug 22, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@eg-ayoub eg-ayoub requested a review from TeddyAndrieux August 22, 2023 16:24
@bert-e
Copy link
Contributor

bert-e commented Aug 23, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@eg-ayoub eg-ayoub force-pushed the improvement/configure-KubeJobNotCompleted-alert branch from 3085a1f to 9961618 Compare August 24, 2023 07:29
@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

History mismatch

Merge commit #3085a1fb5c39a6d69abba5317860f25a490562a2 on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@eg-ayoub
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@eg-ayoub eg-ayoub force-pushed the improvement/configure-KubeJobNotCompleted-alert branch from 9961618 to da485c0 Compare August 24, 2023 07:56
@bert-e
Copy link
Contributor

bert-e commented Aug 24, 2023

History mismatch

Merge commit #9961618c02ef1856e75b0be0e4d1e31842bb52fe on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@TeddyAndrieux TeddyAndrieux force-pushed the improvement/configure-KubeJobNotCompleted-alert branch 4 times, most recently from 7cd0488 to 69e9157 Compare August 25, 2023 06:30
@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2023

History mismatch

Merge commit #d44358dbf96594cb74d33c4cb7e35ae9b2c80a6f on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

TeddyAndrieux
TeddyAndrieux reviewed Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two last minor comments and good to me (if you may also squash a bit the commit to remove the "fixes" commit)

salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls Outdated Show resolved Hide resolved
salt/metalk8s/addons/prometheus-operator/deployed/kube-alerts-rules.sls Outdated Show resolved Hide resolved
@eg-ayoub eg-ayoub requested a review from TeddyAndrieux August 25, 2023 07:50
@eg-ayoub
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@bert-e
Copy link
Contributor

bert-e commented Aug 25, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@eg-ayoub eg-ayoub force-pushed the improvement/configure-KubeJobNotCompleted-alert branch from acc66d6 to 4778de7 Compare August 28, 2023 09:07
@bert-e
Copy link
Contributor

bert-e commented Aug 28, 2023

History mismatch

Merge commit #da7ed8546d0c5967a5ae2fb56881241932d1fb50 on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@eg-ayoub
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following reviewers are expecting changes from the author, or must review again:

@eg-ayoub eg-ayoub force-pushed the improvement/configure-KubeJobNotCompleted-alert branch from 4778de7 to 010eba4 Compare August 29, 2023 13:47
@bert-e
Copy link
Contributor

bert-e commented Aug 29, 2023

History mismatch

Merge commit #4ccab3fba3f60976198b753def2722b8543c68e2 on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@eg-ayoub
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Aug 30, 2023

History mismatch

Merge commit #4ccab3fba3f60976198b753def2722b8543c68e2 on the integration branch
w/126.0/improvement/configure-KubeJobNotCompleted-alert is merging a branch which is neither the current
branch improvement/configure-KubeJobNotCompleted-alert nor the development branch
development/126.0.

It is likely due to a rebase of the branch improvement/configure-KubeJobNotCompleted-alert and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: approve

@eg-ayoub
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2023

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2023

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Aug 31, 2023

Build failed

The build for commit did not succeed in branch w/126.0/improvement/configure-KubeJobNotCompleted-alert.

The following options are set: approve

@eg-ayoub
Copy link
Contributor Author

eg-ayoub commented Sep 4, 2023

ping

@bert-e
Copy link
Contributor

bert-e commented Sep 4, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/125.0

  • ✔️ development/126.0

The following branches will NOT be impacted:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@eg-ayoub
Copy link
Contributor Author

eg-ayoub commented Sep 5, 2023

ping

@bert-e
Copy link
Contributor

bert-e commented Sep 5, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/125.0

  • ✔️ development/126.0

The following branches have NOT changed:

  • development/123.0
  • development/124.0
  • development/124.1
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye eg-ayoub.

@bert-e bert-e merged commit 010eba4 into development/125.0 Sep 5, 2023
72 checks passed
@bert-e bert-e deleted the improvement/configure-KubeJobNotCompleted-alert branch September 5, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyAndrieux TeddyAndrieux TeddyAndrieux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eg-ayoub @bert-e @TeddyAndrieux