Ease Federated App deployment on Workload Plane #4124

MonPote · 2023-08-14T15:16:05Z

Component:

salt, csc

Context:

In order to deploy federated app in an easier way on the workloadplane, we introduce here a new workloadplane configuation for Shell UI and a new default backend for the WP ingress.

bert-e · 2023-08-14T15:16:08Z

Hello monpote,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2023-08-14T15:16:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

…n the WorkloadPlane

…n the Workloadplane

bert-e · 2023-08-17T12:16:59Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

…WP is exposed on the CP

tests/post/steps/test_ingress.py

salt/metalk8s/addons/nginx-ingress/deployed/init.sls

bert-e · 2023-09-06T09:25:37Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-07T03:17:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-07T11:18:39Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2023-09-08T15:46:43Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

MonPote · 2023-09-09T14:40:08Z

/approve

bert-e · 2023-09-09T14:40:15Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

bert-e · 2023-09-11T08:18:15Z

Build failed

The build for commit did not succeed in branch improvement/shell-ui-configuration-for-workload-plane.

The following options are set: approve

JBWatenbergScality · 2023-09-11T08:18:43Z

/status

bert-e · 2023-09-11T08:18:47Z

Status

Status report is not available.

The following options are set: approve

bert-e · 2023-09-11T08:18:55Z

Build failed

The build for commit did not succeed in branch improvement/shell-ui-configuration-for-workload-plane.

The following options are set: approve

MonPote · 2023-09-11T09:40:01Z

ping

bert-e · 2023-09-11T09:40:14Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/126.0

The following branches will NOT be impacted:

development/123.0
development/124.0
development/124.1
development/125.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2023-09-11T12:11:55Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/126.0

The following branches have NOT changed:

development/123.0
development/124.0
development/124.1
development/125.0
development/2.0
development/2.1
development/2.10
development/2.11
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye monpote.

MonPote force-pushed the improvement/shell-ui-configuration-for-workload-plane branch from ba4658a to 38fd94d Compare August 14, 2023 15:43

MonPote marked this pull request as ready for review August 14, 2023 15:45

MonPote requested a review from a team as a code owner August 14, 2023 15:45

MonPote requested a review from TeddyAndrieux August 14, 2023 15:46

MonPote added 3 commits August 14, 2023 18:23

salt: Add support in CSC to manage a new configuration for Shell UI o…

6628582

…n the WorkloadPlane

Changelog: Add an entry mentionning the new CSC config for shell-ui o…

a9cd71e

…n the Workloadplane

salt: Define workloadplane ingress default backend to be Shell UI

8945aae

MonPote force-pushed the improvement/shell-ui-configuration-for-workload-plane branch from 38fd94d to 8945aae Compare August 14, 2023 16:23

MonPote added 3 commits August 17, 2023 14:54

tests: refactor tests according to new default backend behaviour

f286452

tests: add the should not respond with shell-ui check

24005e5

tests: add the should not respond with shell-ui check for cases when …

f79c835

…WP is exposed on the CP

TeddyAndrieux reviewed Aug 17, 2023

View reviewed changes

tests/post/steps/test_ingress.py Outdated Show resolved Hide resolved

TeddyAndrieux reviewed Aug 17, 2023

View reviewed changes

tests/post/steps/test_ingress.py Outdated Show resolved Hide resolved

Remove unneccessary converter

bcf201b

TeddyAndrieux reviewed Aug 17, 2023

View reviewed changes

tests/post/steps/test_ingress.py Outdated Show resolved Hide resolved

MonPote added 2 commits August 17, 2023 15:41

Ensure default backend service and deployment are deleted during upgrade

9724b93

Ensure default backend service account is deleted during upgrade

4af40f5

TeddyAndrieux reviewed Aug 17, 2023

View reviewed changes

salt/metalk8s/addons/nginx-ingress/deployed/init.sls Outdated Show resolved Hide resolved

MonPote and others added 3 commits August 17, 2023 15:49

Ensure default backend deployment is deleted during upgrade

d54f0e3

Fix test useless parser

b224440

Fix linter issues

25ff21a

Fix linter issues

53329db

MonPote and others added 2 commits September 7, 2023 15:19

tests: fix e2e test by adding contexr

e49c4cb

Fix end to end tests

087f2c4

ci

75a7a7e

JBWatenbergScality approved these changes Sep 11, 2023

View reviewed changes

bert-e merged commit 7780a69 into development/126.0 Sep 11, 2023
5 checks passed

bert-e deleted the improvement/shell-ui-configuration-for-workload-plane branch September 11, 2023 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ease Federated App deployment on Workload Plane #4124

Ease Federated App deployment on Workload Plane #4124

MonPote commented Aug 14, 2023

bert-e commented Aug 14, 2023

bert-e commented Aug 14, 2023

bert-e commented Aug 17, 2023

bert-e commented Sep 6, 2023

bert-e commented Sep 7, 2023

bert-e commented Sep 7, 2023

bert-e commented Sep 8, 2023

MonPote commented Sep 9, 2023

bert-e commented Sep 9, 2023

bert-e commented Sep 11, 2023

JBWatenbergScality commented Sep 11, 2023

bert-e commented Sep 11, 2023

bert-e commented Sep 11, 2023

MonPote commented Sep 11, 2023

bert-e commented Sep 11, 2023

bert-e commented Sep 11, 2023

Ease Federated App deployment on Workload Plane #4124

Ease Federated App deployment on Workload Plane #4124

Conversation

MonPote commented Aug 14, 2023

bert-e commented Aug 14, 2023

Hello monpote,

bert-e commented Aug 14, 2023

Waiting for approval

bert-e commented Aug 17, 2023

Waiting for approval

bert-e commented Sep 6, 2023

Waiting for approval

bert-e commented Sep 7, 2023

Waiting for approval

bert-e commented Sep 7, 2023

Waiting for approval

bert-e commented Sep 8, 2023

Waiting for approval

MonPote commented Sep 9, 2023

bert-e commented Sep 9, 2023

Waiting for approval

bert-e commented Sep 11, 2023

Build failed

JBWatenbergScality commented Sep 11, 2023

bert-e commented Sep 11, 2023

Status

bert-e commented Sep 11, 2023

Build failed

MonPote commented Sep 11, 2023

bert-e commented Sep 11, 2023

In the queue

bert-e commented Sep 11, 2023