salt: Add retry on DynamicClient creation to avoid flaky

[TeddyAndrieux]

No description provided.

[bert-e]

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @JBWatenbergScality

• @thomasdanan

• @lucieleonard

• @gdemonet

• @TeddyAndrieux

• @ChengYanJin

[bert-e]

Integration data created

I have created the integration data for the additional destination branches.

• this pull request will merge bugfix/fix-flaky-on-dynamic-client-creation into
  development/124.1
• w/125.0/bugfix/fix-flaky-on-dynamic-client-creation will be merged into development/125.0

The following branches will NOT be impacted:

• development/123.0
• development/124.0
• development/2.0
• development/2.1
• development/2.10
• development/2.11
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7
• development/2.8
• development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• one peer

Peer approvals must include at least 1 approval from the following list:

• @JBWatenbergScality

• @thomasdanan

• @lucieleonard

• @gdemonet

• @TeddyAndrieux

• @ChengYanJin

[gdemonet]

Oh, wouldn't expect this to fail, good catch! How did you see it, btw? Never caught logs about it, personally...

[TeddyAndrieux]

Oh, wouldn't expect this to fail, good catch! How did you see it, btw? Never caught logs about it, personally...

It's the famous

Failed to load ext_pillar metalk8s_endpoints: HTTPSConnectionPool(host='127.0.0.1', port=7443): Max retries exceeded with url: /version (Caused by ProtocolError('Connection aborted.', OSError(0, 'Error')))

It was not super easy to catch and reproduce but was able to do it with some loop on applying states (and with this fix it did not fail once while running during the whole night)

[TeddyAndrieux]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ development/124.1

• ✔️ development/125.0

The following branches will NOT be impacted:

• development/123.0
• development/124.0
• development/2.0
• development/2.1
• development/2.10
• development/2.11
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7
• development/2.8
• development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ development/124.1

• ✔️ development/125.0

The following branches have NOT changed:

• development/123.0
• development/124.0
• development/2.0
• development/2.1
• development/2.10
• development/2.11
• development/2.2
• development/2.3
• development/2.4
• development/2.5
• development/2.6
• development/2.7
• development/2.8
• development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.