Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts,salt,build: Bump NGINX Ingress chart to v4.2.5 #3879

Merged
merged 1 commit into from
Sep 29, 2022
Merged

charts,salt,build: Bump NGINX Ingress chart to v4.2.5 #3879

merged 1 commit into from
Sep 29, 2022

Conversation

TeddyAndrieux
Copy link
Collaborator

@TeddyAndrieux TeddyAndrieux commented Sep 27, 2022 •
edited
Loading

Bump the NGINX Ingress chart to v4.2.5 and also bump the ingress controller image to v1.3.1

@TeddyAndrieux TeddyAndrieux requested a review from a team as a code owner September 27, 2022 13:51
@TeddyAndrieux
charts,salt,build: Bump NGINX Ingress chart to v4.2.5
26487cb 
Bump the NGINX Ingress chart to v4.2.5 and also bump the ingress
controller image to v1.3.1

Upgrade NGINX Ingress chart using:
```
rm -rf charts/ingress-nginx
helm repo add ingress-nginx https://kubernetes.github.io/ingress-nginx
helm repo update
helm fetch -d charts --untar ingress-nginx/ingress-nginx
```

Re-render NGINX Ingress salt states using:
```
./doit.sh codegen:chart_ingress-nginx
```
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/bump-ingress-controller branch from 16142f5 to 26487cb Compare September 27, 2022 14:12
@TeddyAndrieux TeddyAndrieux changed the base branch from improvement/bump-prometheus-adapter to development/124.0 September 27, 2022 14:12
@bert-e
Copy link
Contributor

bert-e commented Sep 27, 2022

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 27, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux TeddyAndrieux marked this pull request as draft September 27, 2022 20:14
@TeddyAndrieux TeddyAndrieux marked this pull request as ready for review September 27, 2022 20:14
@TeddyAndrieux TeddyAndrieux reopened this Sep 27, 2022
@TeddyAndrieux TeddyAndrieux changed the base branch from development/124.0 to development/123.0 September 27, 2022 20:17
@bert-e

This comment was marked as outdated.

Sign in to view
@bert-e
Copy link
Contributor

bert-e commented Sep 27, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux TeddyAndrieux changed the base branch from development/123.0 to development/124.0 September 27, 2022 20:17
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Sep 28, 2022

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 29, 2022

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/124.0

The following branches will NOT be impacted:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Sep 29, 2022

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/124.0

The following branches have NOT changed:

  • development/123.0
  • development/2.0
  • development/2.1
  • development/2.10
  • development/2.11
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit 26487cb into development/124.0 Sep 29, 2022
@bert-e bert-e deleted the improvement/bump-ingress-controller branch September 29, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdemonet gdemonet gdemonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @gdemonet