Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetalK8s UI: Fix the bug of the CP/WP avg metrics #3616

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Nov 29, 2021

Component: UI

Context:
The avg of Control plane bandwidth and Workload bandwidth is not correctly computed on the UI side.
which cause the AVG is always bigger than any of the single node

Summary:

Acceptance criteria:


Closes: #ISSUE_NUMBER

@ChengYanJin ChengYanJin requested a review from a team as a code owner November 29, 2021 18:17
@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2021

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2021

Branches have diverged

This pull request's source branch bugfix/fix-the-bug-of-node-avg-metrics has diverged from
development/2.11 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/2.11 into bugfix/fix-the-bug-of-node-avg-metrics
  • Rebase bugfix/fix-the-bug-of-node-avg-metrics onto origin/development/2.11

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@ChengYanJin ChengYanJin changed the base branch from development/2.11 to development/2.10 November 29, 2021 18:17
@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2021

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

  • ✔️ development/2.11

  • ✔️ development/123.0

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye chengyanjin.

@bert-e bert-e merged commit 7545c68 into development/2.10 Nov 30, 2021
@bert-e bert-e deleted the bugfix/fix-the-bug-of-node-avg-metrics branch November 30, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants