Use webpack module federation to aggregate UIs and solutions UIs #3414

JBWatenbergScality · 2021-06-04T18:26:39Z

Component:

ui

Context:

We are studying options to improve overall user experience while browsing the UI when several solutions UI are deployed and registered in the common navbar configuration.

Summary:

This PR introduces a set of changes to convert the common navbar to a bidirectional federated host (https://github.com/module-federation/module-federation-examples/tree/master/bi-directional) that can load UI remote bundle at runtime and hence be able to render an UI depending on a dynamic context where new solutions can be deployed / upgraded independently than the Metalk8s Shell-UI

Acceptance criteria:

End2End tests, documentation and design docs should be released.

bert-e · 2021-06-04T18:26:41Z

Hello jbwatenbergscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

bert-e · 2021-06-07T07:43:16Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-07-01T22:45:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2021-07-06T10:03:38Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

…ng it from /config.json

… app

…sue them

…r in micor apps using react router

…raries

JBWatenbergScality · 2021-07-07T12:17:05Z

/approve

bert-e · 2021-07-07T12:17:14Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/2.10

The following branches will NOT be impacted:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2021-07-07T12:17:19Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/2.10

The following branches have NOT changed:

development/2.0
development/2.1
development/2.2
development/2.3
development/2.4
development/2.5
development/2.6
development/2.7
development/2.8
development/2.9

Please check the status of the associated issue None.

Goodbye jbwatenbergscality.

JBWatenbergScality requested review from MonPote and ChengYanJin June 4, 2021 18:26

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch from ce37460 to 489648a Compare June 7, 2021 07:43

scality deleted a comment from bert-e Jun 7, 2021

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 5 times, most recently from 4660acd to 536d1db Compare June 28, 2021 14:58

ChengYanJin force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from aaa9ca1 to b7827e9 Compare June 28, 2021 15:24

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 3 times, most recently from 05ba155 to 7021156 Compare June 28, 2021 22:46

ChengYanJin force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from f287d2a to c683b7f Compare July 4, 2021 14:20

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 5 times, most recently from 0ecd24e to 8019b35 Compare July 5, 2021 22:39

JBWatenbergScality changed the title ~~[WIP] Use webpack module federation to aggregate UIs and solutions UIs~~ Use webpack module federation to aggregate UIs and solutions UIs Jul 6, 2021

JBWatenbergScality marked this pull request as ready for review July 6, 2021 07:46

JBWatenbergScality requested a review from a team as a code owner July 6, 2021 07:46

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch 2 times, most recently from d5b7c20 to aeb1b6f Compare July 6, 2021 15:46

JBWatenbergScality and others added 23 commits July 7, 2021 12:29

ui: Use config from runtime app config web finger instead of refetchi…

5cc0757

…ng it from /config.json

salt: Runtime app configuration

fdb21a7

ui: Create voume, remove unnecessary intl.formatMessage

dde5678

salt: CSC framework for deployed ui apps

d5eeb13

shell: Webpack add entry.js in bundled index.html

b777e3c

shell-ui: Bump module federation library

3751631

ci: fixes

748ca30

ui: Use shell index.html for local dev

a1a694a

ui: Upgrade react-query to support module federation context sharing

8bf778d

shell: Add an error boundary in case of error while rendering a micro…

45c9c00

… app

shell: Attach shared context to the window to enable micro apps to re…

0deb434

…sue them

shell: Import css and font

c0cea5e

ui: Fix integration test

1974714

ui: Fetch the app runtime config before fetching the basename

044e94a

shell-ui: Expose the UIListProvider module

32ffb0d

ui: Expose the platform library

3c28bb8

shell,ui: bump module federation library

58b809e

docs: Update developer docs to run the UI locally

ccd1774

changelog: Add an entry referring module federation changes

cb1e262

ui: Expose /config.json configuration for backward compatibility

6b3141c

shell: Introduce a ShellHistoryProvider to enable use of useLinkOpene…

8c28201

…r in micor apps using react router

ui,salt,shell: Add backward compatibility for alerts and platform lib…

1a2a90f

…raries

shell: Fix selected tab for non federated entries

7389da7

JBWatenbergScality force-pushed the improvement/shell-ui-switch-to-module-federation branch from b09f04e to 7389da7 Compare July 7, 2021 10:33

ChengYanJin approved these changes Jul 7, 2021

View reviewed changes

bert-e merged commit 7389da7 into development/2.10 Jul 7, 2021

bert-e deleted the improvement/shell-ui-switch-to-module-federation branch July 7, 2021 12:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use webpack module federation to aggregate UIs and solutions UIs #3414

Use webpack module federation to aggregate UIs and solutions UIs #3414

JBWatenbergScality commented Jun 4, 2021 •

edited

Loading

bert-e commented Jun 4, 2021

bert-e commented Jun 7, 2021

bert-e commented Jul 1, 2021

bert-e commented Jul 6, 2021

JBWatenbergScality commented Jul 7, 2021

bert-e commented Jul 7, 2021

bert-e commented Jul 7, 2021

Use webpack module federation to aggregate UIs and solutions UIs #3414

Use webpack module federation to aggregate UIs and solutions UIs #3414

Conversation

JBWatenbergScality commented Jun 4, 2021 • edited Loading

bert-e commented Jun 4, 2021

Hello jbwatenbergscality,

bert-e commented Jun 7, 2021

Waiting for approval

bert-e commented Jul 1, 2021

Waiting for approval

bert-e commented Jul 6, 2021

Waiting for approval

JBWatenbergScality commented Jul 7, 2021

bert-e commented Jul 7, 2021

In the queue

bert-e commented Jul 7, 2021

JBWatenbergScality commented Jun 4, 2021 •

edited

Loading