Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialitation of Development/2.10 branch #3354

Merged
merged 4 commits into from
May 6, 2021
Merged

Initialitation of Development/2.10 branch #3354

merged 4 commits into from
May 6, 2021

Conversation

TeddyAndrieux
Copy link
Collaborator

  • Bump project version to 2.10
  • Bump Kubernetes version to 1.21.0
  • Bump CoreDNS to 1.8.0
  • Update Dex chart because of a bug with Dex and k8s 1.21

@TeddyAndrieux TeddyAndrieux added topic:build Anything related to building steps complexity:easy Something that requires less than a day to fix kind:dependencies Pull requests that update a dependency file labels May 5, 2021
@TeddyAndrieux TeddyAndrieux requested a review from a team May 5, 2021 16:52
@bert-e
Copy link
Contributor

bert-e commented May 5, 2021

Hello teddyandrieux,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented May 5, 2021

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@TeddyAndrieux
build: Bump Kubernetes version to 1.21.0
4cbff7b
@TeddyAndrieux
build: Bump CoreDNS version to 1.8.0
fef27ec
@TeddyAndrieux
chart,salt: Explicitly set Dex namespace from env
a7376af 
This just explicitly set Dex namespace for Dex container from
environment variable since it's needed as Dex does not yet support
Kubernetes version 1.21

Render chart command:
```
./charts/render.py dex \
  --namespace metalk8s-auth charts/dex.yaml \
  --service-config dex metalk8s-dex-config \
  metalk8s/addons/dex/config/dex.yaml.j2 metalk8s-auth \
  --remove-manifest Secret dex \
  charts/dex/ > salt/metalk8s/addons/dex/deployed/chart.sls
```

Sees: dexidp/dex#2082
@TeddyAndrieux TeddyAndrieux force-pushed the improvement/init-210 branch from 9e852fb to a7376af Compare May 5, 2021 16:54
@TeddyAndrieux
Copy link
Collaborator Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 6, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/2.10

The following branches will NOT be impacted:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 6, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.10

The following branches have NOT changed:

  • development/2.0
  • development/2.1
  • development/2.2
  • development/2.3
  • development/2.4
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue None.

Goodbye teddyandrieux.

@bert-e bert-e merged commit a7376af into development/2.10 May 6, 2021
@bert-e bert-e deleted the improvement/init-210 branch May 6, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-allard alexandre-allard alexandre-allard approved these changes

Assignees
No one assigned
Labels
complexity:easy Something that requires less than a day to fix kind:dependencies Pull requests that update a dependency file topic:build Anything related to building steps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeddyAndrieux @bert-e @alexandre-allard