[ui] Bugfix: monitoring page cannot display all the alerts #2503
Conversation
For some reason, if we set the height of the table to 100% we can't see the last few rows. Refs: #2495
Hello chengyanjin,My role is to assist you with the merge of this Status report is not available. |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/2.6/bugfix/2495-monitoring-page-cannot-display-all-the-alerts origin/development/2.6
$ git merge origin/bugfix/2495-monitoring-page-cannot-display-all-the-alerts
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/2.6/bugfix/2495-monitoring-page-cannot-display-all-the-alerts |
| .sc-loader { | ||
| padding: 0 ${padding.smaller}; | ||
| } | ||
| `; | ||
|
|
||
| const TableContainer = styled.div` | ||
| height: 100%; | ||
| height: 80%; |
There was a problem hiding this comment.
For some reason, if we set the height of the table to 100% we can't see the last few rows.
If the component is from us, we should investigate why.
If it's a third-party library, we could report the bug to them.
There was a problem hiding this comment.
Yes! We should know the root problem.
We are planning to replace this table library actually.
Because it causes too much issue than the value it brings.
We will do some research on the table.
ChengYanJin
changed the title
|
@ChengYanJin how do we scroll down? I don't see any scroll bar ... |
The scroll bar doesn't occur all the time ;) |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list:
|
|
/approve |
|
/status |
StatusStatus report is not available. The following options are set: approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue None. Goodbye chengyanjin. |
bert-e
deleted the
bugfix/2495-monitoring-page-cannot-display-all-the-alerts
branch
Component: ui
Context:
When the number of alerts is more than the capacity of the table, we can't scroll down to check the last few alerts.
Summary:
Change the height of the table from 100% to 80%
Acceptance criteria:
We can scroll down until the end of the table.
Closes: #2495