Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade script stop and exit 1 right after first backup #3570

Closed
TeddyAndrieux opened this issue Oct 19, 2021 · 0 comments
Closed

Upgrade script stop and exit 1 right after first backup #3570

TeddyAndrieux opened this issue Oct 19, 2021 · 0 comments
Assignees
@TeddyAndrieux
Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working release:blocker An issue that blocks a release until resolved topic:lifecycle Issues related to upgrade or downgrade of MetalK8s

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented Oct 19, 2021 •
edited
Loading

Component:

"upgrade"

What happened:

If you try to upgrade using the upgrade script it just silently stop right after the first backup

> Performing Pre-Upgrade checks... done[5s]
> Backing up MetalK8s configurations... done [0s]
> Backing up CAs certificates and keys... done [0s]
> Backing up etcd data... done [1s]
> Creating backup archive '/var/lib/metalk8s/backups/20211019_055703.tar.gz'... done [0s]
## STOP and exit 1 ##

It's because we skip backup replication at the beginning of the upgrade process and backup script wrongly exit 1 in this case

What was expected:

Working upgrade script

Steps to reproduce

Try to upgrade from 2.10.4+
@TeddyAndrieux TeddyAndrieux added kind:bug Something isn't working topic:lifecycle Issues related to upgrade or downgrade of MetalK8s complexity:easy Something that requires less than a day to fix release:blocker An issue that blocks a release until resolved labels Oct 19, 2021
@TeddyAndrieux TeddyAndrieux self-assigned this Oct 19, 2021
@TeddyAndrieux TeddyAndrieux mentioned this issue Oct 19, 2021
Merged
@bert-e bert-e closed this as completed in b75547c Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TeddyAndrieux TeddyAndrieux

Labels
complexity:easy Something that requires less than a day to fix kind:bug Something isn't working release:blocker An issue that blocks a release until resolved topic:lifecycle Issues related to upgrade or downgrade of MetalK8s
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TeddyAndrieux