Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Loki configuration customizable with CSC #2684

Closed
alexandre-allard opened this issue Jul 29, 2020 · 1 comment
Closed

Make Loki configuration customizable with CSC #2684

alexandre-allard opened this issue Jul 29, 2020 · 1 comment
Assignees
Labels
complexity:easy Something that requires less than a day to fix kind:enhancement New feature or request topic:log Anything related to log centralization system

Comments

@alexandre-allard
Copy link
Contributor

Component: salt, loki

Why this is needed:
To be able to customize Loki configuration in a persistent way.

What should be done:
Expose Loki configuration through a CSC ConfigMap.

Implementation proposal (strongly recommended):
Loki's configuration is stored as a Secret.
Since we do not have Operator and CRs for Loki, we will use the CSC mechanism to provide the interface for customization, with a ConfigMap metalk8s-loki-config in the metalk8s-logging Namespace.

The CSC ConfigMap will look like the followings:

  apiVersion: v1
  kind: ConfigMap
  metadata:
    name: metalk8s-loki-config
    namespace: metalk8s-logging
  data:
    config.yaml: |-
      apiVersion: addons.metalk8s.scality.com
      kind: LokiConfig
      spec:
        deployment:
          replicas: 1
        config:
          auth_enabled: false
          chunk_store_config:
            max_look_back_period: 168h
          ingester:
            chunk_block_size: 262144
            chunk_idle_period: 3m
            chunk_retain_period: 1m
            [...]

With default values fetched from a YAML file as it is already done for Dex, Alertmanager and Prometheus.

Test plan:

@alexandre-allard alexandre-allard added kind:enhancement New feature or request topic:log Anything related to log centralization system labels Jul 29, 2020
@alexandre-allard alexandre-allard added the complexity:easy Something that requires less than a day to fix label Aug 5, 2020
@alexandre-allard alexandre-allard self-assigned this Aug 12, 2020
@alexandre-allard
Copy link
Contributor Author

done in #2722

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix kind:enhancement New feature or request topic:log Anything related to log centralization system
Projects
None yet
Development

No branches or pull requests

1 participant