Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for raw (non-formatted) volume in the UI #2660

Open
slaperche-scality opened this issue Jul 8, 2020 · 1 comment
Open

Add support for raw (non-formatted) volume in the UI #2660

slaperche-scality opened this issue Jul 8, 2020 · 1 comment
Labels
complexity:easy Something that requires less than a day to fix priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments topic:ui UI-related issues

Comments

@slaperche-scality
Copy link
Contributor

Component:

ui

Why this is needed:

We now support formatted and non-formatted volume, but from the UI we can only create formatted volume.

What should be done:

On the volume creation page, add way (a dropdown?) to select the volume mode (either Filesystem or Block, default being Filesystem).

Not sure if we want to expose k8s vocabulary (Filesystem/Block) or another term (Formatted/Non-formatted)? To be defined.

Implementation proposal:

  • add a way to get the volume mode from the user
  • then use this information to generate the CRD, e.g.:
apiVersion: storage.metalk8s.scality.com/v1alpha1
kind: Volume
metadata:
  name: foo
spec:
  nodeName: master-1
  storageClassName: metalk8s-prometheus
  mode: Block // or   mode: Filesystem
  rawBlockDevice:
    devicePath: "/dev/vdb"

Test plan:

TBD

@slaperche-scality slaperche-scality added the topic:ui UI-related issues label Jul 8, 2020
@gdemonet
Copy link
Contributor

We should make sure the implications of doing this are well explained to the user (maybe a warning when selecting Block mode, or simply a tooltip explaining the two options).

@thomasdanan thomasdanan added complexity:easy Something that requires less than a day to fix priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments labels Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix priority:medium Medium priority issues, should only be postponed if no other option severity:medium Medium impact (usability) on live deployments topic:ui UI-related issues
Projects
None yet
Development

No branches or pull requests

3 participants