Test, csc restore do not work properly

[TeddyAndrieux]

Component:

'tests'

What happened:

During CSC test we change the number of replicas (and other stuff) to test the change apply properly and after we restore initial state, but the restore only restore the CSC config map and not the real k8s object.

E.g.: After csc test for Dex we have a clean CM but still have replicas set to 3 in the deployment

[root@metalk8s-24-bootstrap-restore-bootstrap ~]# kubectl get cm -n metalk8s-auth metalk8s-dex-config -o yaml
apiVersion: v1
data:
  config.yaml: |
    apiVersion: addons.metalk8s.scality.com
    kind: DexConfig
    spec: {}
kind: ConfigMap
metadata:
  creationTimestamp: "2020-05-25T09:07:03Z"
  labels:
    app.kubernetes.io/managed-by: salt
    heritage: salt
    metalk8s.scality.com/version: 2.5.1-dev
  name: metalk8s-dex-config
  namespace: metalk8s-auth
  resourceVersion: "16658"
  selfLink: /api/v1/namespaces/metalk8s-auth/configmaps/metalk8s-dex-config
  uid: eeab4b44-d290-4c8f-8fb7-4ef782d78e4b

[root@metalk8s-24-bootstrap-restore-bootstrap ~]# kubectl get deploy -n metalk8s-auth dex -o yaml
apiVersion: apps/v1
kind: Deployment
metadata:
[...]
  name: dex
  namespace: metalk8s-auth
[...]
spec:
  [...]
  replicas: 3
[...]

What was expected:

Restoring properly the k8s object in our test

Steps to reproduce

Run CSC test

Resolution proposal (optional):

Call the salt state during restore_csc in pytest

[TeddyAndrieux]

Fixed by #2570