Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests proxy configuration #2123

Open
alexandre-allard opened this issue Dec 11, 2019 · 1 comment
Open

Tests proxy configuration #2123

alexandre-allard opened this issue Dec 11, 2019 · 1 comment
Labels
complexity:easy Something that requires less than a day to fix topic:ci Continuous integration and build orchestration topic:tests What's not tested may be broken

Comments

@alexandre-allard
Copy link
Contributor

alexandre-allard commented Dec 11, 2019

Component: tests, ci

Why this is needed:
To ensure that everything works fine when a proxy is set

What should be done:
We need to test the setting of an http(s) proxy during the metalk8s multiple nodes installation scenario.

Implementation proposal (strongly recommended):
Just add a dummy proxy (pointing to a non-existent address) in the bootstrap.yaml configuration

proxies:
  http: http://10.10.10.10:1234
  https: https://10.10.10.10:1234

Related to: #2052

@alexandre-allard alexandre-allard added topic:tests What's not tested may be broken moonshot topic:ci Continuous integration and build orchestration complexity:easy Something that requires less than a day to fix labels Dec 11, 2019
@gdemonet
Copy link
Contributor

gdemonet commented Dec 11, 2019

I'd argue it would be more useful to set up a realistic env, where proxy sits between containerd and the Internet, and we use it to fetch an arbitrary image (crictl pull -d gcr.io/etcd:3.4.3 for instance) in addition to one from our internal registry (that the proxy cannot resolve, by design).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Something that requires less than a day to fix topic:ci Continuous integration and build orchestration topic:tests What's not tested may be broken
Projects
None yet
Development

No branches or pull requests

2 participants