Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not safe approach for etcd initial-cluster-state #2102

Closed
TeddyAndrieux opened this issue Dec 6, 2019 · 0 comments · Fixed by #2198
Closed

Not safe approach for etcd initial-cluster-state #2102

TeddyAndrieux opened this issue Dec 6, 2019 · 0 comments · Fixed by #2198
Assignees
Labels
kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages

Comments

@TeddyAndrieux
Copy link
Collaborator

TeddyAndrieux commented Dec 6, 2019

Component:

'salt'

What happened:

In our salt states to deploy etcd we set initial-cluster-state to new if we get an empty member list from pillar, that approach may create a initial-cluster-state new for a new node deployment if for what ever reason we are not able to retrieve the list of etcd member.

initial comment #2099 (comment)

What was expected:

initial-cluster-state should be set to new only for the first etcd node (likely the bootstrap one)

Resolution proposal (optional):

TBD:
Suggestion: this value should be existing by default and we force to new only in the bootstrap script (also make the state raise an error if state=existing and we have empty etcd member list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working topic:deployment Bugs in or enhancements to deployment stages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants