From d9367fac66baa0d4a8cb307f7f2594b2f893d7d2 Mon Sep 17 00:00:00 2001 From: Guillaume Demonet Date: Wed, 16 Nov 2022 09:57:41 +0100 Subject: [PATCH] salt: Remove metalk8s.volumes from highstate This was added to ensure loop devices backed by sparse files had an updated logic after upgrading (with systemd units). The side-effect is that upgrading a system where device paths have changed (e.g. because of a reboot and different load order) can break, since running `metalk8s_volumes.is_prepared` on such devices will return False, and raise when we try to format them. Since this is not needed anymore (the units will already exist), and can be added back in the future if required, it is safe to remove for now. --- CHANGELOG.md | 3 +++ salt/metalk8s/roles/node/init.sls | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 54f5054ae6..a97c08d18d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,9 @@ in [124.0.0](https://github.com/scality/metalk8s/releases/124.0.0) changelog) (PR[#3909](https://github.com/scality/metalk8s/pull/3909)) +- Do not attempt to provision Volumes in highstate (this avoids breaking when + device paths have changed between reboots) + (PR[#3913](https://github.com/scality/metalk8s/pull/3913)) ## Release 124.0.0 diff --git a/salt/metalk8s/roles/node/init.sls b/salt/metalk8s/roles/node/init.sls index 2864c8d514..1b3ca32c13 100644 --- a/salt/metalk8s/roles/node/init.sls +++ b/salt/metalk8s/roles/node/init.sls @@ -4,4 +4,3 @@ include: - metalk8s.kubernetes.apiserver-proxy - metalk8s.internal.preflight - metalk8s.beacon.certificates - - metalk8s.volumes