Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bf: check if Expiration rule exists before EODM #294

Merged
merged 1 commit into from
May 29, 2018
Merged

bf: check if Expiration rule exists before EODM #294

merged 1 commit into from
May 29, 2018

Conversation

philipyoo
Copy link
Contributor

From Error logs:
TypeError: Cannot read property 'ExpiredObjectDeleteMarker' of undefined

jonathan-gramain
jonathan-gramain previously approved these changes May 18, 2018
View reviewed changes
Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test that catches this issue? I guess not since it would have failed 🤣 would be good to have one then.

@philipyoo philipyoo force-pushed the bf/fixRuleCheckOnEODM branch from 8073af8 to 922cc8e Compare May 25, 2018 21:43
@ironman-machine ironman-machine dismissed jonathan-gramain’s stale review May 25, 2018 21:43

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@philipyoo philipyoo force-pushed the bf/fixRuleCheckOnEODM branch from 922cc8e to a9096b5 Compare May 25, 2018 21:51
@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

jonathan-gramain
jonathan-gramain previously approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests!

@philipyoo
bf: check if Expiration rule exists before EODM
b3a5568 
Error logs:
TypeError: Cannot read property 'ExpiredObjectDeleteMarker' of undefined
@philipyoo philipyoo force-pushed the bf/fixRuleCheckOnEODM branch from a9096b5 to b3a5568 Compare May 29, 2018 21:54
@ironman-machine ironman-machine dismissed jonathan-gramain’s stale review May 29, 2018 21:54

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit 1ded458 into z/1.0 May 29, 2018
@rahulreddy rahulreddy deleted the bf/fixRuleCheckOnEODM branch May 29, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dora-korpar dora-korpar dora-korpar approved these changes

@tmacro tmacro tmacro approved these changes

@bennettbuchanan bennettbuchanan bennettbuchanan approved these changes

@JianqinWang JianqinWang JianqinWang approved these changes

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@philipyoo @ironman-machine @jonathan-gramain @JianqinWang @bennettbuchanan @tmacro @dora-korpar @rahulreddy