share helpers for gc #271
Merged
share helpers for gc #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-gramain
force-pushed
the
rf/ZENKO-143-shareHelpersForGC
branch
from
a3b0edf to
d8608f7
Compare
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
previously approved these changes
Apr 27, 2018
Move attachReqUids() helper to lib/client/utils.js. This to done to share the simple but useful logic across extensions.
jonathan-gramain
force-pushed
the
rf/ZENKO-143-shareHelpersForGC
branch
from
d8608f7 to
aa469ed
Compare
ironman-machine
dismissed
philipyoo’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
previously approved these changes
May 29, 2018
tmacro
previously approved these changes
May 29, 2018
Move account-credentials gathering in a single getAccountCredentials()
helper in AccountCredentials.js, instead of having to check the type
of authentication ('account' or 'service') and create the class
accordingly.
jonathan-gramain
force-pushed
the
rf/ZENKO-143-shareHelpersForGC
branch
from
aa469ed to
9a8d14f
Compare
ironman-machine
dismissed stale reviews from philipyoo and tmacro
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
|
PR has been updated. Reviewers, please be cautious. |
philipyoo
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small refactors to prepare backbeat garbage collector implementation
rf: ZENKO-143 move attachReqUids() helper
Move attachReqUids() helper to lib/client/utils.js. This to done to
share the simple but useful logic across extensions.
rf: ZENKO-143 add helper getAccountCredentials()
Move account-credentials gathering in a single getAccountCredentials()
helper in AccountCredentials.js, instead of having to check the type
of authentication ('account' or 'service') and create the class
accordingly.