Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helpers): remove extra quotes on flatten #354

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

Sh4d1
Copy link
Contributor

@Sh4d1 Sh4d1 commented Dec 4, 2019

Signed-off-by: Patrik Cyvoct [email protected]

@ghost ghost added the size/XS label Dec 4, 2019
Copy link
Contributor

@kindermoumoute kindermoumoute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (cc @jerome-quere)

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Dec 4, 2019

Wait, it's not working 😅

@Sh4d1
Copy link
Contributor Author

Sh4d1 commented Dec 4, 2019

Sorry, it's working 😅

@Sh4d1 Sh4d1 force-pushed the fix_sec_group_range branch from 4d94272 to 95ae3fe Compare December 4, 2019 14:49
@Sh4d1 Sh4d1 changed the title fix(sg): allow port_range fix(helpers): remove extra quotes on flatten Dec 4, 2019
@jerome-quere jerome-quere merged commit 390f193 into scaleway:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants