fix(iam_ssh_key): do not read public key in resource #2695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused the value to differ from requested input and this can lead to issue in terraform if the value is used in other resources. Also as it cannot be updated, it seems right to assume the local key is the correct key
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2695 +/- ##
==========================================
- Coverage 71.43% 71.02% -0.42%
==========================================
Files 277 334 +57
Lines 35875 33511 -2364
==========================================
- Hits 25628 23800 -1828
+ Misses 8028 7402 -626
- Partials 2219 2309 +90 ☔ View full report in Codecov by Sentry. |
remyleone
reviewed
Aug 7, 2024
| @@ -55,6 +55,14 @@ func ResourceSSKKey() *schema.Resource { | |||
| areEqual := bytes.Equal(marshalledOldValue, marshalledNewValue) | |||
| return areEqual | |||
| }, | |||
| StateFunc: func(v interface{}) string { | |||
There was a problem hiding this comment.
Could you add a bit of documentation explaining that the last part of the public key will be trimmed.
|
Could you do additional testing to ensure that the formatting happening in the terraform state is consistant with the key stored on the IAM backend? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused the value to differ from requested input and this can lead to issue in terraform if the value is used in other resources.
Also as it cannot be updated, it seems right to assume the local key is the correct key