Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scaleway region is invalid #426

Closed
tboerger opened this issue Oct 28, 2016 · 2 comments
Closed

New scaleway region is invalid #426

tboerger opened this issue Oct 28, 2016 · 2 comments

Comments

@tboerger
Copy link

The scaleway provider has launched a new region, but this is currently invalid within the scaleway provider definition because the vendored client is outdated. Since it's not documented how to properly update these libs I need some assistence to fix that.

/cc @nicolai86

@nicolai86
Copy link
Contributor

@tboerger I normally copy the files from scaleway-cli/pkg/ into vendor/github.com/scaleway/scaleway-cli and delete the helpers.go afterwards.

helpers.go pulls in a bunch of dependencies which itself amount of a huge bloat, and we don't need that at all for terraform.

I've long wanted to refactor the scaleway go SDK to remove this, effectivly make a lightweight version of their SDK not bound to their CLI implementation, but didn't find the time yet. It's a bigger undertaking.

Hope this helps! Basically two simple steps to update the SDK on terraforms side :)

@tboerger
Copy link
Author

And I just realized now that I have posted this issue to the wrong repo, I wanted to post it to terraform of course. Thanks, will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants