feat: automate Crossplane generation process #26
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 347
Lines ? 33787
Branches ? 0
======================================
Hits ? 0
Misses ? 33787
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
config/tools/comparator/main.go
Outdated
| } | ||
|
|
||
| config := tools.ResourceConfig{ | ||
| PackageName: strings.ToLower(strings.ReplaceAll(resource.SubCategory, " ", "")), // Convert "Apple Silicon" to "applesilicon" |
There was a problem hiding this comment.
Could you extract it and include some tests for this function? I'm betting that it will be probably from this piece of code that we will have unexpected behavior in some code generation.
| "text/template" | ||
|
|
||
| "github.com/pkg/errors" | ||
| "github.com/scaleway/provider-scaleway/config/tools" |
There was a problem hiding this comment.
Is crossplane missing here? What is the go.mod you are targeting with this?
| const ExternalNameGoFilePath = "config/external_name.go" | ||
|
|
||
| func parseTemplates() (*template.Template, error) { | ||
| templatePath := "config/config_templates.tmpl" |
There was a problem hiding this comment.
Could it be a embedding static file? That way if we try to compile if the file is missing/moved the compilation step won't pass.
| id: check_release | ||
| run: ./scripts/check_version.sh | ||
|
|
||
| - name: Read Current Terraform Provider Version from Makefile |
There was a problem hiding this comment.
I would like to have the full workflow inside a script so that it can be launched locally even if github action is down
No description provided.