Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalameta: upgrade to 4.4.32 (scaladoc fixes) #3054

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

kitbellew
Copy link
Collaborator

No description provided.

@kitbellew kitbellew requested review from dos65 and tgodzik January 12, 2022 20:18
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a single question from me.

sb.append(tagMargin)
formatTextAfterMargin(x, tagMargin)
case _ => appendBreak()
appendBreak()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not break for @usecase ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will not, @dos65 and i changed tags with a label and no description to behave like usecase and take the entire line rather than single word.

@kitbellew kitbellew merged commit cbab792 into scalameta:master Jan 13, 2022
@kitbellew kitbellew deleted the 3054 branch January 13, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants