From e3ab8fe999324863e23069b5d0570b5b827e168d Mon Sep 17 00:00:00 2001 From: Tim Nieradzik Date: Fri, 1 May 2020 11:16:59 +0100 Subject: [PATCH] Runner: Fix Scala.js linking error When the libraries `scalajs-test-interface` and `scalajs-junit-test-runtime` are placed before MUnit in the classpath, the following linking error occurs: ``` org.junit.runner.Runner (of kind Class) is not a valid interface implemented by munit.MUnitRunner (of kind Class) ``` Solve this by defining an `abstract class` instead of a `trait` to match JUnit's [`Runner`](https://junit.org/junit4/javadoc/4.12/org/junit/runner/Runner.html). See also #114. --- munit/non-jvm/src/main/scala/org/junit/runner/Runner.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/munit/non-jvm/src/main/scala/org/junit/runner/Runner.scala b/munit/non-jvm/src/main/scala/org/junit/runner/Runner.scala index af93049d..2c716ed0 100644 --- a/munit/non-jvm/src/main/scala/org/junit/runner/Runner.scala +++ b/munit/non-jvm/src/main/scala/org/junit/runner/Runner.scala @@ -2,7 +2,7 @@ package org.junit.runner import org.junit.runner.notification.RunNotifier -trait Runner { +abstract class Runner { def run(notifier: RunNotifier): Unit def getDescription(): Description }