Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

afterAll() does not run after all fixtures have been torn down #539

Closed
armanbilge opened this issue Jun 19, 2022 · 2 comments
Closed

afterAll() does not run after all fixtures have been torn down #539

armanbilge opened this issue Jun 19, 2022 · 2 comments

Comments

@armanbilge
Copy link
Contributor

The scaladoc says:

/** Runs once after all test cases and after all suite-local fixtures have been tear down. */
def afterAll(): Unit = ()

But this doesn't seem to be the case in typelevel/munit-cats-effect#208 (comment).

@armanbilge
Copy link
Contributor Author

armanbilge commented Jun 19, 2022

This seems like a deliberate change in #430 based on the diff to the FixtureOrderFrameworkSuite. @olafurpg can you confirm this was intended? Thanks!

@armanbilge
Copy link
Contributor Author

Aha, apologies for noise. This is specifically covered in the release notes under "breaking changes".
https://github.com/scalameta/munit/releases/tag/v1.0.0-M1

@armanbilge armanbilge closed this as not planned Won't fix, can't repro, duplicate, stale Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant