Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of local functions misses end marker #5797

Closed
keynmol opened this issue Oct 28, 2023 · 1 comment · Fixed by #5803
Closed

Renaming of local functions misses end marker #5797

keynmol opened this issue Oct 28, 2023 · 1 comment · Fixed by #5803
Labels
rename Scala 3 Generic ticket relating to Scala 3
Milestone

Comments

@keynmol
Copy link
Contributor

keynmol commented Oct 28, 2023

Describe the bug

CleanShot 2023-10-28 at 13 31 28

Expected behavior

As with top level functions, I expect the end marker to be renamed as well (just like with top level function)

Operating system

macOS

Editor/Extension

Nvim (nvim-metals)

Version of Metals

1.1.0+39-f985a070-SNAPSHOT

Extra context or search terms

rename, end marker, function, scala 3

@tgodzik
Copy link
Contributor

tgodzik commented Oct 28, 2023

Thanks for reporting! I think the issue might be that for local values we use the presentation compiler. We might need to get the end marker position from the unttped tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rename Scala 3 Generic ticket relating to Scala 3
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants