Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When .mill-jvm-opts doesn't end with a newline, the last parameter is ignored #4557

Closed
phfroidmont opened this issue Oct 21, 2022 · 1 comment
Labels
BSP Generic BSP related tickets mill Mill related tickets upstream-fix-needed Waiting on a fix upstream

Comments

@phfroidmont
Copy link

Describe the bug

Have a .mill-jvm-opts file to define custom JVM parameters, without a newline at the end

-Xss10m
-Xmx10G

mill-bsp runs a mill process with the -Xss10m parameter but without -Xmx10G

Expected behavior

mill-bsp runs a mill process with all parameters defined in .mill-jvm-opts.

When adding a newline at the end of the file, the issue doesn't appear.

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v0.11.9

Extra context or search terms

mill-bsp v0.10.8

@ckipp01
Copy link
Member

ckipp01 commented Oct 22, 2022

Thanks for the issue @phfroidmont although Metals doesn't have anything to actually do with the .mill-jvm-opts file. Metals will follow the instructions to start the BSP server that are found in the .bsp/mill-bsp.json file. Then it's up to the server to handle starting up correctly and doing things like reading its various files like you have listed here. You'll need to actually raise this issue over in Mill.

@ckipp01 ckipp01 closed this as completed Oct 22, 2022
@ckipp01 ckipp01 added mill Mill related tickets upstream-fix-needed Waiting on a fix upstream BSP Generic BSP related tickets labels Oct 22, 2022
@tgodzik tgodzik added this to the Metals v0.11.10 milestone Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP Generic BSP related tickets mill Mill related tickets upstream-fix-needed Waiting on a fix upstream
Projects
None yet
Development

No branches or pull requests

3 participants