Rename Rewrite to Checker/Rule?

[olafurpg]

Following discussion in #291 (comment).

Now that rewrites can emit linter warnings, the name "Rewrite" may be confusing for linters that don't rewrite. Would it make sense to rename scalafix.Rewrite to scalafix.rule?

[olafurpg]

After having looked around names clang-tidy, fb infer and pylint use, I think a more appropriate name for a scalafix rewrite would be a "Checker".

[gabro]

Just to throw another one in the mix, eslint uses Rule and rules can be "fixable". But I'm totally ok with Checker

[olafurpg]

Interesting. I think Rule is equally fine then.

Question is, what should Rewrite.rewrite become then?

Rewrite.rewrite
Checker.check
Rule.rule ?
Rule.check ?
Rule.apply ?

[xeno-by]

I vote for Checker.check.

[gabro]

Ok, let the bike shedding begin! 🚲

Checker is ok, but I would expect a checker to only check, not to actually do anything.

Rule is instead more "prescriptive": here's the rule, and you can either:

• check it
• apply a fix

Rule.check
Rule.fix

(this follows eslint's convention)

[olafurpg]

Rule it is! We discussed this at the Scala Center meeting yesterday and we were unanimously in favor of Rule.fix/Rule.check over Checker. PR coming soon!