Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zinc and Scala versions #1382

Closed
IlyaHalsky opened this issue Oct 8, 2020 · 3 comments
Closed

Zinc and Scala versions #1382

IlyaHalsky opened this issue Oct 8, 2020 · 3 comments

Comments

@IlyaHalsky
Copy link

Hi,

I've noticed when calling bloop about it prints Using Scala v2.12.8 and Zinc v1.3.0-M4+45-d4354be3,
I get why Scala version could be outdated, but Zinc is now 1.4.0 (4 days ago) with previous minor version being v1.3.5 (Mar 30).
Is it intentional?

@tgodzik
Copy link
Contributor

tgodzik commented Oct 8, 2020

Thanks for the question! Bloop is using a separate fork of zinc, I don't remember exactly why, but I think it was connected to some changes needed for Bloop itself, which weren't possible merge upstream.

We should probably update the fork though.

@Duhemm
Copy link
Collaborator

Duhemm commented Oct 8, 2020

Thanks for reporting @IlyaHalsky. Bloop is using a fork of Zinc, which includes some features that weren't available in vanilla Zinc at the time (build pipelining, for instance).

I'd personally be in favor of migrating back to sbt/zinc since it now includes all of the features that our fork has, and I believe it has received a significant number of other improvements that haven't been ported to our fork.

@Duhemm
Copy link
Collaborator

Duhemm commented Oct 8, 2020

Closing in favor of #1383

@Duhemm Duhemm closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants