To shade or not to shade, that is the question.

[ckipp01]

In an ongoing effort to simplify the Bloop build one of the things that have came up in the past is to move the shading from the custom sbt-shading plugin that lives in Bloop to instead use something like sbt-shading. This seems like a smart move, however it got me thinking a bit about what we're actually shading in Bloop.

What we shade

There is currently only 2 things that we shade in Bloop. The launcher and bloopgun artifacts. Just to give a full picture, here are the two resolved artefacts with their shaded counterparts.

bloopgun

bloopgun-core (non shaded)

❯ cs resolve ch.epfl.scala:bloopgun-core_2.13:1.5.6
ch.epfl.scala:bloopgun-core_2.13:1.5.6:default
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core_2.13:2.13.3.2:default
com.github.scopt:scopt_2.13:4.0.0-RC2:default
io.get-coursier:interface:1.0.6:default
io.get-coursier:interface-svm-subs:1.0.6:default
me.vican.jorge:snailgun-cli_2.13:0.4.0:default
me.vican.jorge:snailgun-core_2.13:0.4.0:default
net.java.dev.jna:jna:5.6.0:default
net.java.dev.jna:jna-platform:5.6.0:default
org.scala-lang:scala-library:2.13.8:default
org.slf4j:slf4j-api:1.7.36:default
org.slf4j:slf4j-nop:1.7.36:default
org.zeroturnaround:zt-exec:1.11:default

bloopgun (shaded

❯ cs resolve ch.epfl.scala:bloopgun_2.13:1.5.6
ch.epfl.scala:bloopgun_2.13:1.5.6:default
org.scala-lang:scala-library:2.13.8:default
org.scala-lang.modules:scala-collection-compat_2.13:2.4.2:default

launcher

launcher-core (non shaded)

❯ cs resolve ch.epfl.scala:bloop-launcher-core_2.13:1.5.6
ch.epfl.scala:bloop-launcher-core_2.13:1.5.6:default
ch.epfl.scala:bloopgun-core_2.13:1.5.6:default
ch.epfl.scala:sockets:1.5.6:default
com.github.plokhotnyuk.jsoniter-scala:jsoniter-scala-core_2.13:2.13.3.2:default
com.github.scopt:scopt_2.13:4.0.0-RC2:default
io.get-coursier:interface:1.0.6:default
io.get-coursier:interface-svm-subs:1.0.6:default
me.vican.jorge:snailgun-cli_2.13:0.4.0:default
me.vican.jorge:snailgun-core_2.13:0.4.0:default
net.java.dev.jna:jna:5.12.1:default
net.java.dev.jna:jna-platform:5.12.1:default
org.scala-lang:scala-library:2.13.8:default
org.slf4j:slf4j-api:1.7.36:default
org.slf4j:slf4j-nop:1.7.36:default
org.zeroturnaround:zt-exec:1.11:default

launcher (shaded)

❯ cs resolve ch.epfl.scala:bloop-launcher_2.13:1.5.6
ch.epfl.scala:bloop-launcher_2.13:1.5.6:default
net.java.dev.jna:jna:4.5.0:default
net.java.dev.jna:jna-platform:4.5.0:default
org.scala-lang:scala-library:2.13.8:default
org.scala-lang.modules:scala-collection-compat_2.13:2.4.2:default

Do they need to be

Looking at the dependency chains, I'm wondering if these need to actually be shaded. Looking at when this was added in #1032 it's not clear if this was done as a precaution or if it was actually causing issues. If we could remove the shading in the Bloop build we could really further simplify some things. This leaves me with a couple questions:

• Can we remove the shading? A couple people that might have more context here (@alexarchambault @tgodzik @Duhemm)
• If we can't remove the shading, do we need to continue to publish both shaded and non-shaded variants?