Allow click prompt for SAM 2 #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks for implementing the frontend part so fast @philippotto.
Please find my potential improvements below
frontend/javascripts/oxalis/controller/combinations/tool_controls.ts
Outdated
Show resolved
Hide resolved
frontend/javascripts/oxalis/model/sagas/quick_select_ml_saga.ts
Outdated
Show resolved
Hide resolved
…ossos.DEV.flags.sam.useLocalMask = false)
| selectionBottomRightXOpt: Option[Int], | ||
| selectionBottomRightYOpt: Option[Int], | ||
| pointXOpt: Option[Int], | ||
| pointYOpt: Option[Int], | ||
| dataShape: Vec3Int, // two of the axes will be 1024, the other is the "depth". Axis order varies depending on viewport |
There was a problem hiding this comment.
TODO: remove / adapt comment
fm3
reviewed
Aug 19, 2024
This reverts commit 8362003.
|
@MichaelBuessemeyer could you have a look at my latest commits? I think, afterwards the PR might be good to merge. |
philippotto
approved these changes
Aug 19, 2024
dieknolle3333
pushed a commit
that referenced
this pull request
Sep 2, 2024
* backend: add support for point interaction * format backend * fix buffer size calculation of buffer sent to torchserve * support point interaction with sam-based quick select * tmp enable SAM and disable most of ci * improve comments * update nux text * tweak width of nux * incorporate feedback * undo tmp changes * fix busy-mutex violated * make backend accept sam bboxes with width / height less than 1024 * refactor a bit (e.g.,DEV flags) * use a local bounding box for SAM by default (can be toggled via webknossos.DEV.flags.sam.useLocalMask = false) * tune busy blocking msg * refactor WkDevFlags further * remove unused import * tmp: disable some ci steps * update comment in backend about torchserver request params * fix that the padding could make the bbox too large * use viewport extent in correct mag as minimum for mask size * Revert "tmp: disable some ci steps" This reverts commit 8362003. * also mention clicking in quick select tooltip (and docs) * update changelog * add tooltip with hints for sam * improve styling of hint * improve tooltip text --------- Co-authored-by: Philipp Otto <[email protected]> Co-authored-by: Philipp Otto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)