Minor Upgrades for Backend Dependencies #7782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fm3
commented
May 2, 2024
| // Makes txw2 write self-closing tags in xml (which we want). Not imported. | ||
| "org.codehaus.woodstox" % "wstx-asl" % "4.0.6", | ||
| // Json Web Tokens (used for OIDC Auth). import pdi.jwt | ||
| "com.github.jwt-scala" %% "jwt-play-json" % "9.2.0", | ||
| "com.github.jwt-scala" %% "jwt-play-json" % "10.0.0", |
There was a problem hiding this comment.
https://github.com/jwt-scala/jwt-scala/releases says no breaking changes, just the play 3 upgrade
fm3
changed the title
fm3
commented
May 7, 2024
| @@ -68,7 +68,7 @@ class DataVaultTestSuite extends PlaySpec { | |||
| "returns failure" when { | |||
| "requesting invalid range" in { | |||
| val result = (vaultPath / dataKey) | |||
| .readBytes(Some(Range.Long(-10, 10, 1)))(globalExecutionContext) | |||
| .readBytes(Some(Range.Long(-5, -10, 1)))(globalExecutionContext) | |||
There was a problem hiding this comment.
Negative starts for byte ranges are now actually allowed in GCS. So we need to test an even more invalid range to check that a failure is indeed returned (this test is intended to check that no exceptions bubble up but instead the tryo turns them into Box.Failures).
MichaelBuessemeyer
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to test: