Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add text in case no data is shown in timetracking overview #7736

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Add text in case no data is shown in timetracking overview #7736

merged 5 commits into from
Apr 9, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Apr 4, 2024 •
edited
Loading

Steps to test:

  • Go to time tracking overview and select a range/filters without any tracked times.
  • Make sure an appropriate text is displayed, rather than "no data"

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Removed dev-only changes like prints and application.conf edits

@dieknolle3333 dieknolle3333 self-assigned this Apr 4, 2024
hotzenklotz
hotzenklotz approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) April 9, 2024 14:45
@dieknolle3333 dieknolle3333 merged commit ab82fd2 into master Apr 9, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the time-tracking-no-no-data branch April 9, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzenklotz hotzenklotz hotzenklotz approved these changes

Assignees

@dieknolle3333 dieknolle3333

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dieknolle3333 @hotzenklotz