-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ND data loading with other axis orders #7592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good job!
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/AxisOrder.scala
Outdated
Show resolved
Hide resolved
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/AxisOrder.scala
Outdated
Show resolved
Hide resolved
val chunkIndices = ChunkUtils.computeChunkIndices(datasetShape.map(axisOrder.permuteIndicesReverse), | ||
axisOrder.permuteIndicesReverse(chunkShape), | ||
val chunkIndices = ChunkUtils.computeChunkIndices(datasetShape.map(fullAxisOrder.permuteIndicesArrayToWk), | ||
fullAxisOrder.permuteIndicesArrayToWk(chunkShape), | ||
shape, | ||
totalOffset) | ||
if (partialCopyingIsNotNeeded(shape, totalOffset, chunkIndices)) { | ||
for { | ||
chunkIndex <- chunkIndices.headOption.toFox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chunkIndex <- chunkIndices.headOption.toFox | |
chunkIndexInWk <- chunkIndices.headOption.toFox |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m hesitant, because then we would have to annotate shape, offset, chunkIndices, sourceChunk as well. It’s true that this ordering is important to understanding this function, but it is not the only thing going on here, so I’m scared the renamings would generate too much noise. Instead, I tried to make the comment more descriptive. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine, either way this PR should be an improvement.
Steps to test:
TODOs:
Issues: