Clean up and improve how mismatching resolutions are detected #4936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The nightly test fails in one test case due to "mismatching resolutions". However that failure was a false positive, which is caused by the fact that we keep the original resolutions per layer instead of storing the "densified version". The code had problems with a dataset where the resolutions were like this:
The old code densified the resolutions (i.e., padded all the missing resolutions for the second layer) and assumed that the longest resolution list covers all resolutions. The new code constructs a union of all resolutions and checks that there are no mismatches while doing so.
URL of deployed dev instance (used for testing):
Steps to test:
Issues: