Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce TaskType Resolution Restrictions for Multi-Res Volume Tasks #4891

Merged
merged 47 commits into from
Nov 5, 2020
Merged

Enforce TaskType Resolution Restrictions for Multi-Res Volume Tasks #4891

merged 47 commits into from
Nov 5, 2020

Commits on Oct 23, 2020

  1. [WIP] enforce task type magnification settings in tasks

    @fm3
    fm3 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    21f009f View commit details
    Browse the repository at this point in the history

  2. pass allowedMagnifications to rpc methods

    @fm3
    fm3 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    a377520 View commit details
    Browse the repository at this point in the history

  3. pass magnifications as query string

    @fm3
    fm3 committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    fa6613c View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. respect resolution restrictions for volume tracings.

    @fm3
    fm3 committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    ecc3035 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. add option to downsample existing volume tracing

    @fm3
    fm3 committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    6855901 View commit details
    Browse the repository at this point in the history

  2. remove outdated assertion, update resolution list after downsampling

    @fm3
    fm3 committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    4094f32 View commit details
    Browse the repository at this point in the history

  3. sleep 10s

    @fm3
    fm3 committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    d4890eb View commit details
    Browse the repository at this point in the history

  4. remove sleep and bump dev-proxy-timeout to 5 min

    @philippotto
    philippotto committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    2a65db2 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. fix task creation with resolution restrictions

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    3c0205a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'multires-volumes' into multires-volumes-restricted

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    219a47d View commit details
    Browse the repository at this point in the history

  3. use inclusive check

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    3282035 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    0fcad72 View commit details
    Browse the repository at this point in the history

  5. when uploading zips with differing resolution sets, fail

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    6766c92 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    89c622a View commit details
    Browse the repository at this point in the history

  7. remove unused import

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    09004c5 View commit details
    Browse the repository at this point in the history

  8. refresh snapshots (tracings contain organization name)

    @fm3
    fm3 committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    a2561e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. write header.wkw to every mag in volume download, fix anisotropic dir… 

    …ectory names
    @fm3
    fm3 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    2643726 View commit details
    Browse the repository at this point in the history

  2. add resolution-samenss assertion in volume dnd import. fix flow types

    @fm3
    fm3 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    aca011d View commit details
    Browse the repository at this point in the history

  3. fix restriction passing in initial data

    @fm3
    fm3 committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    bc7178c View commit details
    Browse the repository at this point in the history

  4. Add button to trigger downsampling of volume annotation. 

    The reload button next to the active-resolution-indicator only appears
for explorative annotations with volume data. It opens a modal which
explains the action and its consequences. While the operation is
running, the modal blocks further usages of webKnossos. After the
operation has completed, the complete page is reloaded.
    @philippotto
    philippotto committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    695d101 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    d0f673b View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. fix parameter passing in duplicate rpc

    @fm3
    fm3 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    022e0f8 View commit details
    Browse the repository at this point in the history

  2. avoid undefined behavior of bucket iterator by checking hasNext. do n… 

    …ot relabel when “merging” only one volume
    @fm3
    fm3 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    2dbf12e View commit details
    Browse the repository at this point in the history

  3. make tasktype resolution restrictions immutable. sort resolution list

    @fm3
    fm3 committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    e92bf9a View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. update migration guide

    @fm3
    fm3 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    5ab1743 View commit details
    Browse the repository at this point in the history

  2. remove debug output

    @fm3
    fm3 committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    9f15bd2 View commit details
    Browse the repository at this point in the history

  3. improve initiate-volume-downsampling modal and move its button to the… 

    … layer settings
    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    09fb073 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    2171f5d View commit details
    Browse the repository at this point in the history

  5. show toast when mag-restriction is violated instead of prohibiting th… 

    …e zoom change in the first place
    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    0c7c41b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'multires-volumes' into multires-volumes-restricted

    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    a95d9a8 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'multires-volumes' into multires-volumes-restricted

    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    d8d622a View commit details
    Browse the repository at this point in the history

  8. don't allow editing mag-restrictions in already created tasktype

    @philippotto
    philippotto committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    10143cd View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. remove some more debug output, unify variable names

    @fm3
    fm3 committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    6ea304d View commit details
    Browse the repository at this point in the history

  2. forbid creating new nodes or using volume tools when the current mag … 

    …was forbidden by the task type
    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    5535ba4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    1a681cb View commit details
    Browse the repository at this point in the history

  4. clean up

    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a5edb7f View commit details
    Browse the repository at this point in the history

  5. Update MIGRATIONS.unreleased.md 

    Co-authored-by: Philipp Otto <[email protected]>
    @fm3 @philippotto
    fm3 and philippotto authored Nov 4, 2020
    Configuration menu
    Copy the full SHA
    a5152b3 View commit details
    Browse the repository at this point in the history

  6. fix styling of button-link

    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    8b4e07b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    0722933 View commit details
    Browse the repository at this point in the history

  8. use ListBuffer instead of HashSet as per pr feedback

    @fm3
    fm3 committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    3888a91 View commit details
    Browse the repository at this point in the history

  9. integrate some feedback

    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    66c43ea View commit details
    Browse the repository at this point in the history

  10. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    4a818db View commit details
    Browse the repository at this point in the history

  11. Apply suggestions from code review 

    Co-authored-by: Daniel <[email protected]>
    @philippotto @daniel-wer
    philippotto and daniel-wer authored Nov 4, 2020
    Configuration menu
    Copy the full SHA
    bf48913 View commit details
    Browse the repository at this point in the history

  12. remove unnecessary SET_TOOL dependence

    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    fa84163 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'multires-volumes-restricted' of github.com:scalablemind… 

    …s/webknossos into multires-volumes-restricted
    @philippotto
    philippotto committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    e3bea0e View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. do map ids if initialLargestSegmentId != 0

    @fm3
    fm3 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    7e34b0d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'multires-volumes' into multires-volumes-restricted

    @fm3
    fm3 committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    1368ae2 View commit details
    Browse the repository at this point in the history