Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment Index + Stats for ND volume annotations #7276

Closed
fm3 opened this issue Aug 17, 2023 · 3 comments · Fixed by #7411
Closed

Segment Index + Stats for ND volume annotations #7276

fm3 opened this issue Aug 17, 2023 · 3 comments · Fixed by #7411

Comments

@fm3
Copy link
Member

fm3 commented Aug 17, 2023

Segment Index that is stored in FossilDB should include additionalCoordinates. We should consider adding these to the key as well (just like the mag) or design a more elaborate lookup structure, depending on the queries we might get.

My guess is that the typical query is for a single spot along the additionalCoordinates axes.

@fm3
Copy link
Member Author

fm3 commented Sep 18, 2023

@frcroth fyi, we added you as assignee, read this as a “whoever of us is out of issues first”. The other issues, especially #6740, #7243 and #7275 are higher priority (and should hopefully require less pending discussion)

@fm3
Copy link
Member Author

fm3 commented Oct 16, 2023

@normanrz @philippotto I think we need some input here.

Currently the segment index maps from a segment id to a list of buckets(xyz).

To adapt this for ND we could make the value a list of buckets (xyz+additionalCoordinates). However, I’m not sure that can answer all relevant queries.

We could also include the additional coordinates in the key instead, so it would be (segment id + additional coordinates) → list of buckets (xyz)

That would support getting the full list for a particular additional-coordinates point (e.g. time-point).

However, on top of that, we might also implement an index for segment id to list of additional coordinates, where this segment exists at all.

This way, we could also answer queries about in which time-points the segment exists.

What do you think?

@normanrz
Copy link
Member

However, on top of that, we might also implement an index for segment id to list of additional coordinates, where this segment exists at all.

This could be done via an index scan, no?

Putting the additional coords in the key sound fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants