Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-Up for Multi-Resolution Support #4838

Open
2 of 7 tasks
philippotto opened this issue Sep 29, 2020 · 0 comments
Open
2 of 7 tasks

Follow-Up for Multi-Resolution Support #4838

philippotto opened this issue Sep 29, 2020 · 0 comments
Labels

Comments

@philippotto
Copy link
Member

philippotto commented Sep 29, 2020

See #4755

  • improve labeling performance (labelVoxelInAllResolutions labels each voxel individually and then also for each mag). consider using LabeledVoxelsMap to batch bucket updates and also directly use their upsampling/downsampling methods
  • the fill-tool only fills the current slice which does not match the behavior of the normal brush
  • Brush preview can be imprecise #7128
  • Brush preview can be imprecise when brushing in higher mag
  • mag restriction only restricts creating new nodes. e.g., deleting a node in a restricted mag is still possible which is a bit inconsistent. not super high-pri and also not super clear how to solve this optimally. deleting a tree should probably be possible in all mags, since it can be done via the trees tab.
  • Refactoring:
    • LabeledVoxelMap could hold more meta information
    • zoomedAddressToAnotherZoomStep should be replaced by zoomedAddressToAnotherZoomStepWithInfo (afterwards, the naming can be shortened probably). We need to be careful here, since the old code could also convert to not existing mags. Often, this should not be necessary, but it needs to be checked on a case-by-case basis.

Feel free to add more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant