Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify naming of "zoomStep" and "resolution" / "resolutionIndex" #4762

Closed
MichaelBuessemeyer opened this issue Aug 10, 2020 · 2 comments
Closed

Unify naming of "zoomStep" and "resolution" / "resolutionIndex" #4762

MichaelBuessemeyer opened this issue Aug 10, 2020 · 2 comments
Labels
frontend refactoring

Comments

@MichaelBuessemeyer
Copy link
Contributor

MichaelBuessemeyer commented Aug 10, 2020 •
edited
Loading

Currently, the frontend uses "zoomStep" and "resolutionIndex" for the same thing and the resolutions in the store are all saved in as "resolutions".

I suggest sticking to one term for the "resolution"/"resolutionIndex". I think "resolutionIndex" is the better term as it works well with the term "resolutions". But on the other hand "zoomStep" is used much more frequent.
@fm3
Copy link
Member

fm3 commented Dec 3, 2020

related: #4893

also note this discussion #4755 (comment)

@fm3 fm3 mentioned this issue Mar 11, 2021
Merged
16 tasks
@fm3
Copy link
Member

fm3 commented Apr 20, 2022

superseded by #4893

@fm3 fm3 closed this as completed Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fm3 @MichaelBuessemeyer