Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume layer opacity does not persist #4650

Closed
cnzqy1 opened this issue Jun 5, 2020 · 7 comments · Fixed by #4845
Closed

Volume layer opacity does not persist #4650

cnzqy1 opened this issue Jun 5, 2020 · 7 comments · Fixed by #4845

Comments

@cnzqy1
Copy link

cnzqy1 commented Jun 5, 2020

After changing the opacity of volume layer in tracing mode (say to 50), if I view a dataset with default segmentation opacity that is different (say 20), then this new opacity (20) is also applied to the tracing mode. Would it be possible to make this setting persistent in tracing mode?

@philippotto
Copy link
Member

The opacity setting is persisted for each dataset (and for each user) independently (regardless of view or tracing mode). At least, this is how it's supposed to be right now if I'm not mistaken.
For example, if you change the opacity for the segmentation layer in dataset A, it should only change if you change it by yourself. When opening another dataset B, the segmentation opacity will default to 20 again for that dataset, but dataset A should still open with the opacity you had before.

You can change the defaults for a given dataset by editing the dataset in the dashboard. That way, you can set the default for all users who will use the dataset (so, this is only interesting for a multi-user setup).

Does this make sense? And does this match the behavior you are experiencing?

@cnzqy1
Copy link
Author

cnzqy1 commented Jun 8, 2020

Yes, that makes sense. It doesn't exactly match the behavior I'm experiencing, however. Seems that it's more complicated than what I described in the initial post, so I'll troubleshoot a bit more to find out what triggers the reset.

@cnzqy1
Copy link
Author

cnzqy1 commented Jun 8, 2020

OK, the actual issue is as following:

  1. Dataset X does not have a segmentation layer.
  2. I make a new segmentation on this dataset using either explorational annotation or task, and change opacity to 50.
  3. After I view the same dataset X in view mode, the default opacity 20 is now propagated to the tracing mode when I open the annotation again.

This issue doesn't seem to occur when the dataset has a pre-existing segmentation layer.

@philippotto
Copy link
Member

Thank you for the detailed reproduction steps! We'll look into fixing this.

@youri-k
Copy link
Contributor

youri-k commented Jul 13, 2020

I could reproduce the bug and trace it's origin to the handling of the user dataset configurations. An easy solution would be to move the alpha value of the layer configuration to the annotation. @MichaelBuessemeyer Do you think this would be feasible in the frontend as well?

@philippotto
Copy link
Member

@MichaelBuessemeyer Do you think this would be feasible in the frontend as well?

Ping :)

@MichaelBuessemeyer
Copy link
Contributor

Sorry for not replaying. I somehow did not see this issue / mention.

Do you think this would be feasible in the frontend as well?

I think that this is possible/ feasible but that would kinda spread the location of where the settings of a layer are saved in the store, which might be confusing. Additionally, if we move the alpha value, shouldn't this step also be necessary for the other configurations (color, intensityRange, etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants