Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose min/max for float layers #4526

Closed
normanrz opened this issue Apr 6, 2020 · 1 comment · Fixed by #4630
Closed

Expose min/max for float layers #4526

normanrz opened this issue Apr 6, 2020 · 1 comment · Fixed by #4630
Assignees
Labels

Comments

@normanrz
Copy link
Member

normanrz commented Apr 6, 2020

With float layers the histogram is necessary for any viewing of the dataset. Sometimes the sampling does not yield sensible results. For these datasets, it would be nice to specify min and max with an input field. Please note that the range of floats can be both very small (e.g. 4.8e-15) and very large (e.g. 3.2e+12).

@philippotto
Copy link
Member

Additional (opinionated) notes:

  • the input fields should be validated against the valid value range of the layer (e.g., only 0-255 should be allowed for uint8)
  • using parseFloat will automatically parse scientific notation (e.g., 4.8e-15). an UI hint could tell the user so (if we find space for that hint)
  • the fields should only be visible after the user clicks an "edit" button, in my opinion. showing these fields all the time for all layers adds too much clutter, otherwise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants