Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default dataset configuration immediately copied to user account? #4481

Closed
fm3 opened this issue Mar 17, 2020 · 1 comment
Closed

Default dataset configuration immediately copied to user account? #4481

fm3 opened this issue Mar 17, 2020 · 1 comment

Comments

@fm3
Copy link
Member

fm3 commented Mar 17, 2020

Quote @youri-k in #4357 (comment):

When you open a new dataset, you get the current dataset default configuration, and instantly respond to the server with this default config as your new user config. When the default config changes afterwards, you won't notice the change because your user config takes precedence. I don't know if this intended, but it's the same on the master. My feeling would be to only save a new user config, if the user actually changes his dataset settings and not just copying the default config at the point of first opening the dataset.

Let’s discuss what the desired behavior would be (also maybe document the entire precedence structure somewhere, as it has become quite involved already)

@youri-k
Copy link
Contributor

youri-k commented Oct 29, 2020

This behavior is intended because not copying the default configuration could lead to unexpected changes when opening the dataset multiple times.
The precedence structure is now explained in the documentation.

@youri-k youri-k closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants