Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

histogram filters zero-values, check if this is intended or change #4328

Closed
fm3 opened this issue Nov 19, 2019 · 1 comment
Closed

histogram filters zero-values, check if this is intended or change #4328

fm3 opened this issue Nov 19, 2019 · 1 comment

Comments

@fm3
Copy link
Member

fm3 commented Nov 19, 2019

in histogram_view.js
value > 0 ? (Math.log(value) / Math.log(maxValue)) * canvasHeight : 0

@MichaelBuessemeyer
Copy link
Contributor

I just checked why there is a > comparison instead of >=. The reason is pretty simple: The logarithm of 0 equals - infinity. Therefore this check is correct. Maybe a comment would be helpful to clarify this :).

I am adding the comment in PR #4349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants