New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix or Remove Morton Order in Volume Data Fossil Keys #3546

Closed

jstriebel opened this issue Dec 7, 2018 · 0 comments · Fixed by #7917

Assignees

Labels

backend low-pri

Contributor

jstriebel commented Dec 7, 2018 •

edited

Loading

Currently the FossilDB keys for volume data contain the Morton Order number. This is currently unused and broken, because

we do not write multiple buckets, so that the Morton order would help.
the Morton order number in the key does not contain leading zeroes, making this useless.
the number only has 32bit which is not enough (breaking around 1000 buckets per dimension). This also lead to negative numbers (leading to bug Download of small volume tracings produces 0 b data.zip #3540), why we are currently not using this part of the key anymore.

We should either remove the Morton order part of the key, or make it useful again at a point. This involves rewriting the database.

jstriebel added backend discussion labels

philippotto added low-pri and removed discussion labels

fm3 mentioned this issue

Unified annotation versioning #7917

Merged

fm3 self-assigned this

fm3 closed this as completed in #7917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment