Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rendering code #2615

Open
1 of 11 tasks
philippotto opened this issue May 18, 2018 · 2 comments
Open
1 of 11 tasks

Refactor rendering code #2615

philippotto opened this issue May 18, 2018 · 2 comments

Comments

@philippotto
Copy link
Member

philippotto commented May 18, 2018

  • Shader
    • Extract main shader code into an own module (ideally, use something like glslify to further split the code)
    • Make the uniform listening more concise and robust
  • Make bucket picker strategies responsible for deciding when they should be triggered
    • each strategy should listen to the attributes it depends on
    • the strategies could be triggered/controlled from within a saga(s)
  • Clean up the render loop. At the moment, it's scattered through out plane_view/arbitrary_plane/arbitrary_view
    • only listen to the minimum of necessary store changes (e.g., for updating the matrix of a rendering plane)
    • try to get rid of backbone events
  • clean up the responsibilities of the scene controller (skeleton and orthogonal mode aspects are mixed)
  • ensure that there are no memory leaks when switching between modes (all listeners should be destroyed)

Log Time

@hotzenklotz
Copy link
Member

Is this still relevant especially in light of recent changes to the rendering pipeline, WebGL2, ThreeJS update, shared rewrites, etc?

@philippotto
Copy link
Member Author

The points are still relevant, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants