Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIP 46 - avoid duplication of jars in binary distribution #20711

Closed
bishabosha opened this issue Jun 21, 2024 · 0 comments · Fixed by #20631
Closed

SIP 46 - avoid duplication of jars in binary distribution #20711

bishabosha opened this issue Jun 21, 2024 · 0 comments · Fixed by #20631
Assignees
Labels
area:runner Issues tied to the scala runner command.

Comments

@bishabosha
Copy link
Member

currently in 3.5.0-RC1 and 3.5.0-RC2 the binary distribution contains both a lib directory, and a maven2 directory, which duplicate the jars necessary to run all of the commands. (About 40MB)

the classpath for scalac and scaladoc commands are resolved from lib, but the new scala command resolves jars from maven2.

I propose to drop the lib directory, and instead tell scalac and scaladoc commands to resolve from maven2 also.

As an implementation detail, we can explicitly write the classpath to a file, which would also solve issue #20413

@bishabosha bishabosha added the stat:needs triage Every issue needs to have an "area" and "itype" label label Jun 21, 2024
@bishabosha bishabosha added needs-minor-release This PR cannot be merged until the next minor release area:runner Issues tied to the scala runner command. and removed stat:needs triage Every issue needs to have an "area" and "itype" label labels Jun 21, 2024
@bishabosha bishabosha removed the needs-minor-release This PR cannot be merged until the next minor release label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:runner Issues tied to the scala runner command.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants